Use TypeaheadSelect in ImageRunModal #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mvollmer
commented
Jan 3, 2025
•
mvollmer
commented
- lib: Some TypeaheadSelect and MultiTypeaheadSelect improvements cockpit#21482
mvollmer
force-pushed
the
pf-stop-using-deprecated-select
branch
4 times, most recently
from
4348cda to
a1bb0a9
Compare
mvollmer
force-pushed
the
pf-stop-using-deprecated-select
branch
2 times, most recently
from
2d0d8c3 to
93fe60e
Compare
|
Registry searching is too slow for our tests on Arch... |
This was always the case, but I got the spinner behavior wrong: The new code would either show images or the spinner (but never both), while the old code would always show the available images plus a spinner if a search was ongoing. |
mvollmer
force-pushed
the
pf-stop-using-deprecated-select
branch
from
93fe60e to
68a71ea
Compare
|
Nice! That pixel diff looks plausible, the "x" change also happened for the other portings. Thanks! 🌟 |
mvollmer
force-pushed
the
pf-stop-using-deprecated-select
branch
from
68a71ea to
fc903b5
Compare
martinpitt
approved these changes
Jan 8, 2025
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.